Re: [Xen-devel] [PATCH] xen: update_runstate_area for 32 bit PV on HVM guests

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 28 May 2010, Jan Beulich wrote:
> >>> On 28.05.10 at 16:45, Stefano Stabellini 
> >>> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/domain.c Thu May 27 09:39:47 2010 +0100
> > +++ b/xen/arch/x86/domain.c Fri May 28 15:42:28 2010 +0100
> > @@ -1315,7 +1315,9 @@
> >          return;
> >  
> >  #ifdef CONFIG_COMPAT
> > -    if ( is_pv_32on64_domain(v->domain) )
> > +    if ( is_pv_32on64_domain(v->domain) ||
> > +         (is_hvm_pv_evtchn_domain(v->domain) &&
> > +          has_32bit_shinfo(v->domain)) )
> >      {
> >          struct compat_vcpu_runstate_info info;
> 
> Is there any reason why this cannot be just has_32bit_shinfo()?
> 
 
no, actually has_32bit_shinfo should be able to cover all cases


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel