Re: [Xen-devel] [PATCH] Speed up superpage mapping, take 2

[Dave McCracken <dcm@xxxxxxxx>]

On Wednesday, May 26, 2010, Keir Fraser wrote:
> On 26/05/2010 08:36, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
> >> -#define __HYPERVISOR_VIRT_START_PAE    0xF5800000
> >> -#define __MACH2PHYS_VIRT_START_PAE     0xF5800000
> >> -#define __MACH2PHYS_VIRT_END_PAE       0xF6800000
> >> +#define __HYPERVISOR_VIRT_START_PAE    0xF5600000
> >> +#define __MACH2PHYS_VIRT_START_PAE     0xF5600000
> >> +#define __MACH2PHYS_VIRT_END_PAE       0xF6600000
> >> 
> >>  #define HYPERVISOR_VIRT_START_PAE      \
> >>  
> >>      mk_unsigned_long(__HYPERVISOR_VIRT_START_PAE)
> >>  
> >>  #define MACH2PHYS_VIRT_START_PAE       \
> > 
> > is absolutely forbidden: You cannot lower the start address of
> > the hypervisor address space hole - no kernel can be expected
> > to be able to deal with that. I think you will need to make the
> > feature 64-bit specific, unless you can find a 2Mb range within
> > the existing hole (but I doubt there is any room left), or unless
> > you map the table dynamically as needed for 32-bits.
> 
> Sixty-four-bit-only is *fine* by me. But yes, the patch will need another
> rev for this.

Sorry, I should have picked up on this.  64 bit only is fine by me too.  I'll 
respin the patch.

Dave McCracken

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel