Re: [Xen-devel] [PATCH] xl: allow nameless domains to be named

[Yang Hongyang <yanghy@xxxxxxxxxxxxxx>]

Hi jeremy,

On 05/26/2010 04:44 AM, Jeremy Fitzhardinge wrote:
> At present, find_domain() will exit(2) if you specify a domain by
> number, but that domain doesn't have a corresponding name.  However,
> nothing seem to critically depend on common_domname being set, and the
> test prevents dom0 or other nameless domains from being named.  So just
> remove the check.

Thank you, for now, remove the check seems to be the solution.

> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>

Acked-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>

> 
> diff -r ba7fdd53f44c tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c        Tue May 25 13:37:20 2010 -0700
> +++ b/tools/libxl/xl_cmdimpl.c        Tue May 25 13:40:53 2010 -0700
> @@ -138,10 +138,6 @@
>          exit(2);
>      }
>      common_domname = was_name ? p : libxl_domid_to_name(&ctx, domid);
> -    if (!common_domname) {
> -        fprintf(stderr, "%s is an invalid domain identifier.\n", p);
> -        exit(2);
> -    }
>  }
>  
>  #define LOG(_f, _a...)   dolog(__FILE__, __LINE__, __func__, _f "\n", ##_a)
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 


-- 
Regards
Yang Hongyang

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel