Re: [Xen-devel] [PATCH] ocaml: fix ocaml xc compilation on 32 bit

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 20/05/2010 13:56, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:

>>> - c_array = malloc(sizeof(xen_pfn_t) * c_nr_pfns);
>>> + c_array = malloc(sizeof(uint64_t) * c_nr_pfns);
>> 
>> Wouldn't it be better to have here
>> 
>> + c_array = calloc(c_nr_pfns, sizeof(uint64_t));
> 
> I suppose so but that would be an unrelated change, please post a patch
> if you think it is worth it.

Who cares either way. calloc() has potential extra overhead for clearing the
memory, which is presumably not required in this case.

 K.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel