Re: [Xen-devel] [PATCH 0/2] xl: Add subcommand mem-max and fix mem-set

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 12 May 2010, Stefano Stabellini wrote:
> On Wed, 12 May 2010, Yu Zhiguo wrote:
> > Yu Zhiguo wrote:
> > > Yu Zhiguo wrote:
> > >> I'm trying to add subcommand 'mem-max', I think xc_domain_setmaxmem 
> > >> should
> > >> be used in it but not here.
> > >>
> > >> I'll move this code to 'mem-max', and in 'mem-set', a check should be 
> > >> added
> > >> because setting memory larger than max memory is invalid.
> > >>
> > >> 1. Add 'mem-max'
> > >>   Add libxl_domain_setmaxmem, it calls xc_domain_setmaxmem.
> > >>   /local/domain/$domid/memory/static-max should be updated when set max 
> > >> memory,
> > >> it is missing now.
> > >>
> > >> 2. fix 'mem-set'
> > >>   Delete xc_domain_setmaxmem.
> > >>   Get max memory from /local/domain/$domid/memory/static-max, and then 
> > >> do value check.
> > >> It seems that we cannot get max memory use libxc routines.
> > >>
> > > 
> > > I fixed it, please check.
> > > 
> > > [PATCH 1/2] xl: Add command 'xl mem-max'
> > > [PATCH 2/2] xl: Add check for command 'xl mem-set'
> > > 
> > 
> > It seems than /local/domain/$domid/memory/target cannot be created when use 
> > 'xl create',
> > only /local/domain/0/memory/static-max is existent.
> > Isn't it a bug? I'll check the code.
> > 
> > I think it should be created like static-max.
> > * memory/target can be created when use 'xm create'
> > 
> 
> Actually sorry if I didn't reply in time before you sent your patches,
> but I asked the xapi memory management expert (CC'ed) an
> opinion on the memset/memmax commands, I have the impression
> that he has something interesting to say about them.
> 
> Keir, could you please wait before applying these patches?
> 

Oops I see now is too late :)
Jonathan, what do you think about them anyway?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel