[Xen-devel] RE: One question to compat model

["Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>]

>-----Original Message-----
>From: Jan Beulich [mailto:JBeulich@xxxxxxxxxx]
>Sent: Wednesday, May 12, 2010 4:31 PM
>To: Jiang, Yunhong
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: RE: One question to compat model
>
>>>> "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> 12.05.10 10:15 >>>
>>The followed small changes cayse compile failed with:
>>
>>can't read compat/domctl.h: No such file or directory
>
>Sure - domctl.h must not be included from xen-mca.h in any case,
>you'll need to move the type declaration if you want to use it outside
>the domctl/sysctl set.

Thanks for remind. Yes, this header will also be included in kernel although 
this specific structure will only be used by tools.

>
>>How can I disable compat model now? I remember that option has been removed.
>
>You can't disable CONFIG_COMPAT anymore, but I think you should
>be able to tweak the CONFIG_COMPAT section in
>xen/arch/x86/cpu/mcheck/mce.c in a way to allow your new code to
>be built without doing anything compat-related for the new
>structures. But maybe removing the domctl.h dependency already
>clarifies matters.

Yes, it should be ok. But a curios question is, why the xenctl_cpumap has to be 
defined in domctl.h. It's simply a helper function. Now I have to work like 
XENPF_getidletime, passing two parameters (nr_cpus and the bitmap pointer), 
combine them in hypervisor to xenctl_cpumap and then call the xenctl_cpumap 
code. And the same to user space tools. 

Thanks for your remind.
--jyh

>
>Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel