[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] vncpassword support in libxl
Gihan Munasinghe writes ("[Xen-devel] [PATCH] vncpassword support in libxl"): > When trying to move xen4.0 and libxl I found that libxl does not support > vncpassword with in the device model. > Was there are particular reason this feature is not implemented . To get > our vms ported in to xen4 and to change our management stack to use > libxl. I have done the following patch what do you guys think. It looks like a mostly reasonable patch, thanks. However you have made a couple of apparently accidental changes: - libxl_exec(null, logfile_w, logfile_w, + libxl_exec(null, logfile_w, logfile_w, ... - printf("Parsing config file %s\n", config_file); and so on. Could people please review your patches by eye - yes, read every line - before sending ? In this case, please resubmit with only the necessary changes. While you're at it, you should probably ensure that you submit a patch which doesn't introduce tabs. I don't mind them but I know some people do. You may want (setq indent-tabs-mode nil) in Emacs. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |