Re: [Xen-devel] [PATCH, v2] reduce 'd' debug key's global impact

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 06.05.10 11:15 >>>
>On 06/05/2010 10:07, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>> Otoh it seems like I will should add irq_enter()/irq_exit() now that the
>> function calls something non-trivial...
>
>Yes, most definitely. They are cheap and should be added unconditionally to
>the handler if you go this route.

Hmm, smp_call_function_interrupt() for example also doesn't do this
unconditionally, so I'd prefer having them only in the unlikely code
path.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel