[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH]xl: move libxl init functions from xl.c to xl_cmdimpl.c
Hi Ian, On 05/06/2010 12:20 AM, Ian Jackson wrote: > Yang Hongyang writes ("[Xen-devel] [PATCH]xl: move libxl init functions from > xl.c to xl_cmdimpl.c"): >> Move libxl init functions from xl.c to xl_cmdimpl.c, use a wrapper function >> xl_init to do libxl init things. > > I don't understand the purpose of this change. It's my mistake that uses extern vars in .c file this way, Keir fix part of it, but there remains two declarations in xl.c. My prupose is to correct this usage. But compare to move these declarations to .h file, I prefer move code related to these vars to xl_cmdimpl.c, because I think the libxl init and set log functions is more related to command implementations. > > Ian. > > -- Regards Yang Hongyang _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |