Re: [Xen-devel] [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi

[Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>]

Hi, Konrad 

Konrad Rzeszutek Wilk wrote:
> 
> perhaps add:
> 
> #else /* This is for CONFIG_XEN */
> 
> static inline int xen_register_gsi(...)
> {
> 
> }
> #endif
> 
> Or maybe better take out the xen_register_gsi out of this double
> #ifdef and move it to its own. Say:
> 
> 
> #if !defined(CONFIG_XEN)
> static int xen_register_gsi(..)
> 
> #endif
> 
> 
>>> ...
>>>   
>> This is a good way of handling it.
> 
> The header file change or the #ifdef in the acpi/boot.c file?

 Thanks for your explanation, I agree it is also a good idea.
But if jeremy think adding #ifdef is ok, I will not fix this patch.


-- 
Regards
Yu Zhiguo


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel