Re: [Xen-devel] [PATCH 03/11] [XEN] NUMA guest tools interface

[Andre Przywara <andre.przywara@xxxxxxx>]

Dulloor wrote:
> The patch adds hypercall interfaces to get/set the virtual numa layout
> for a domain.
I don't see the need for introducing this many new interfaces. I 
couldn't find a reference for the nodemap information (mfn_to_nid) to be 
actually used somewhere, is there any missing part or was it just for 
the sake of completeness?
Beside that, cpu_to_node is already in physinfo, and via xc_availheap 
(which takes a node parameter) you can query the amount of free memory 
per node. I think that is all we need to know about the host's NUMA 
topology, but correct me if I am wrong.
(OK, the distance information is missing...)
From a design point of view I would avoid exporting so many host 
machine information to Dom0 unless we really need it.
Regards,
Andre.

--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel