[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH] pv-grub: fix boot crash when no fb is available
pv-grub: fix boot crash when no fb is available When no fb is available, init_fbfront will return, so the local semaphore for synchronization with the kbd thread would get dropped. Using a global static semaphore instead fixes this. Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> diff -r 8dada4c897c9 stubdom/grub/mini-os.c --- a/stubdom/grub/mini-os.c Sat Mar 06 13:31:42 2010 +0000 +++ b/stubdom/grub/mini-os.c Sun Apr 04 19:13:06 2010 +0200 @@ -651,12 +651,11 @@ return 0; } +static DECLARE_MUTEX_LOCKED(kbd_sem); static void kbd_thread(void *p) { - struct semaphore *sem = p; - kbd_dev = init_kbdfront(NULL, 1); - up(sem); + up(&kbd_sem); } struct fbfront_dev *fb_open(void *fb, int width, int height, int depth) @@ -665,10 +664,9 @@ int linesize = width * (depth / 8); int memsize = linesize * height; int numpages = (memsize + PAGE_SIZE - 1) / PAGE_SIZE; - DECLARE_MUTEX_LOCKED(sem); int i; - create_thread("kbdfront", kbd_thread, &sem); + create_thread("kbdfront", kbd_thread, &kbd_sem); mfns = malloc(numpages * sizeof(*mfns)); for (i = 0; i < numpages; i++) { @@ -681,7 +679,7 @@ if (!fb_dev) return NULL; - down(&sem); + down(&kbd_sem); if (!kbd_dev) return NULL; _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |