Re: [Xen-devel] [PATCH 05/11] libxl: Provide libxl_domain_rename

[Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>]

On 25/03/10 19:04, Ian Jackson wrote:
> Provide a new function libxl_domain_rename.  It can check that the
> domain being renamed has the expected name, to avoid races.
>
> Use the new function to set the name during domain creation.
this looks really ugly (transaction in transaction in domain make), and 
has a really complicated code path (which doesn't look right either on 
the first read), but
my main objection is that libxl has no business handling the uniqueness 
of names or whatever you want to do here. libxl get a name string from 
whoever is using it (xl in your case), so if you want somehow to have a 
special feature make it so in xl. in other words, no policies in libxl.
also NULL is for pointer, 0 for integer values.

--
Vincent

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel