[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH] tmem: typo causes incorrect return on out-of-memory
This classic typo in tmem would result in a false positive report on a tmem "put" operation if a (unfragmented) page of memory is completely unavailable. Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> diff -r b8d2a4134a68 xen/common/tmem.c --- a/xen/common/tmem.c Wed Mar 03 17:41:58 2010 +0000 +++ b/xen/common/tmem.c Tue Mar 09 08:53:12 2010 -0700 @@ -1308,7 +1308,7 @@ copy_uncompressed: copy_uncompressed: if ( ( pgp->pfp = tmem_page_alloc(pool) ) == NULL ) { - ret == -ENOMEM; + ret = -ENOMEM; goto delete_and_free; } /* tmh_copy_from_client properly handles len==0 (TMEM_NEW_PAGE) */ Attachment:
tmem-typo.patch _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |