Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 25/02/2010 13:17, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> /*
> * Check for FACS and DSDT address mismatches. An address mismatch between
> * the 32-bit and 64-bit address fields (FIRMWARE_CTRL/X_FIRMWARE_CTRL and
> * DSDT/X_DSDT) would indicate the presence of two FACS or two DSDT tables.
> */
> if (acpi_gbl_FADT.facs &&
>    (acpi_gbl_FADT.Xfacs != (u64) acpi_gbl_FADT.facs)) {
> ACPI_WARNING((AE_INFO,
>      "32/64X FACS address mismatch in FADT - "
>      "%8.8X/%8.8X%8.8X, using 32",
>      acpi_gbl_FADT.facs,
>      ACPI_FORMAT_UINT64(acpi_gbl_FADT.Xfacs)));
> 
> acpi_gbl_FADT.Xfacs = (u64) acpi_gbl_FADT.facs;
> }

Okay, well I guess that is basically what Gang Wei's patch implements,
although we don't print a warning and perhaps we should.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel