Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 25/02/2010 05:49, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:

> /* Now FACS... */
> - if (fadt->header.revision >= FADT2_REVISION_ID)
> + if (fadt->header.revision >= FADT2_REVISION_ID && fadt->facs == 0)
> facs_pa = fadt->Xfacs;
> else
> facs_pa = (uint64_t)fadt->facs;

I think Linux in this case falls back to facs if Xfacs is zero, rather than
always using facs if facs is non-zero. So more like:
 if (fadt->header.revisions >= FADT2_REVISION_ID && fadt->Xfacs)
    ...

What do you think? And I was looking at Linux 2.6.27 -- has behaviour there
chanegd since then?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel