Re: [Xen-devel] [PATCH] [PVOPS] fix gntdev on PAE

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

On 02/10/2010 04:19 AM, Stefano Stabellini wrote:
> On Tue, 9 Feb 2010, Jeremy Fitzhardinge wrote:
>    
> > On 02/01/2010 07:46 AM, Stefano Stabellini wrote:
> >      
> > > On Mon, 1 Feb 2010, Stefano Stabellini wrote:
> > >
> > >        
> > > > Hi all,
> > > > this small patch fixes gntdev on Linux pvops kernels:
> > > > gnttab_set_map_op and gnttab_set_unmap_op shouldn't take unsigned long
> > > > as parameters for machine addresses because they are not big enough on
> > > > PAE systems.
> > > > This patch fixes the issue using phys_addr_t instead and enables
> > > > XEN_GNTDEV compilation again.
> > > >
> > > >
> > > > Signed-off-by: Stefano Stabellini<stefano.stabellini@xxxxxxxxxxxxx>
> > > >
> > > >
> > > >          
> > > BTW gntdev is used by qemu to provide the console backend to pv guests.
> > >
> > >        
> > Is that recent?  Console had been working before hadn't it?
> >
> > The gntdev problems I saw were more locking related than anything to do
> > with PAE.  Did you try testing with lock debugging enabled?
> >
> >      
> Yes, I don't have any problem with locking in gntdev on my testbox.
>    
OK, I'll give it another go.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel