[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] pvops dom0: no sound after boot; possibly causedby swiotlb



> No, your first statement was correct. It would always return the same mask 
> for 32-bit and 64-bit, because of the 32-bitness of the return-variable 
> 'dma_mask'.
> 
> So the following patch maybe would be more appropriate?

I think it isn't neccessary. The 'dmal_alloc_coherent_mask' returns an
unsigned long. On 32-bit 'unsigned long' is a 4-byte value, and
on 64-bit that is 8-byte value. So I think your previous patch:
http://lists.xensource.com/archives/html/xen-devel/2010-02/msg00038.html
is correct as when it is compiled under 64-bit it would return a 64-bit
value and when compiled under 32-bit, it would return a 32-bit value.
This would mimick the behavior of upstream logic.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.