Re: [Xen-devel] [PATCH] evtchn_do_upcall: search a snapshot of level 2 bits for pending upcalls

[Kaushik Kumar Ram <kaushik@xxxxxxxx>]

On Feb 3, 2010, at 3:32 AM, Keir Fraser wrote:

> On 01/02/2010 19:24, "Kaushik Kumar Ram" <kaushik@xxxxxxxx> wrote:
> 
>>> Somehow the patch is mangled and does not apply. But also it is very big.
>>> How about the attached patch instead? I think it does all we agreed on, and
>>> is much smaller.
>> 
>> Well, I tried really hard to avoid the extra checks inside the loop.
>> Maybe it doesn't matter.
>> 
>> There is one small issue in your patch, otherwise it is fine. When start_l1i
>> is not set, l2i has to be made zero. Otherwise, we would start halfway 
>> through
>> the next l2 whose l1i is set. I think this issue exists even in the original
>> code.
> 
> Thanks Kaushik! I fixed that and checked in as linux-2.6.18-xen:990, which
> will soon appear in the main public repo.

l2i=0 at the end of the outer loop seems redundant. Otherwise it is fine.

Thanks.
-Kaushik
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel