Re: [Xen-devel] [PATCH][v2] Hybrid extension support in Xen

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2010-02-02 at 08:16 +0000, Sheng Yang wrote:
> 
> +static hvm_hypercall_t *hvm_hypercall_hybrid64_table[NR_hypercalls] =
> {
> +    [ __HYPERVISOR_memory_op ] = (hvm_hypercall_t *)hvm_memory_op,
> +    [ __HYPERVISOR_grant_table_op ] = (hvm_hypercall_t
> *)hvm_grant_table_op,
> +    HYPERCALL(xen_version),
> +    HYPERCALL(console_io),
> +    HYPERCALL(vcpu_op),
> +    HYPERCALL(sched_op),
> +    HYPERCALL(event_channel_op),
> +    HYPERCALL(hvm_op),
> +};

Why not just expand the exiting hvm hypercall table to incorporate these
new hypercalls?

In fact, why is hybrid mode considered a separate mode by the hypervisor
at all? Shouldn't it just be an extension to regular HVM mode which
guests may choose to use? This seems like it would eliminate a bunch of
the random conditionals.

Have you verified that all of the operations you are making available
are safe to be called from (hybrid)hvm mode?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel