[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2
On Fri, 2010-01-29 at 03:52 -0500, Keir Fraser wrote: > On 29/01/2010 08:45, "Daniel Stodden" <daniel.stodden@xxxxxxxxxx> wrote: > > > On Fri, 2010-01-29 at 03:29 -0500, Daniel Stodden wrote: > >> On Fri, 2010-01-29 at 03:09 -0500, Keir Fraser wrote: > >>> Echo the changeset comment and sign-off into the email body would be > >>> better, > >>> but your re-send is fine as far as I'm concerned. I should be able to > >>> apply > >>> the attachments no problem. > >> > >> Patchbomb as of hg 1.3.1 doesn't seem to do this. > > > > Ah, it does. > > > > So --inline implies --attach, > > but is still different from --inline *and* --attach. > > > > Sorry for the noise. > > By the way, attaching and inlining a whole patch is also acceptable. Some > people like inline patches, so that they can easily review and comment. I > like attachments because they JustWork when I'm trying to apply big bundles > of patches. To avoid confusion: By inline I meant the content-disposition. The visual results would combine the best of both. But I suspect the results somwhat depend on the mailer in use. It's completely up to you. I don't charge for python cycles. :) So far I got [alias] email-xen = email --attach --inline --to 'Xen <xen-devel@xxxxxxxxxxxxxxxxxxx>' email-xapi = email --review --inline --to 'Xen API <xen-api@xxxxxxxxxxxxxxxxxxx>' Maybe Pasi knows a decent corner on the wiki where this stuff can converge to gatekeeper preferences. > For smaller patches, inline only can be okay. For some reason, I find that > inline large patches rarely apply for me. It's really weird, given I only > fetchmail and munpack the emails, and yet I have a suspicion the mangling > does happen at my end. Heard this before. I doubt fetchmail tries to be smart about the message body. I never worked with munpack. I noticed that mailman adds some filtering even when forwarding, because the content-disposition=inline gets stripped. But I also think mailman breaking diffs would be kind of gross.. Cheers, Daniel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |