Re: [xen-devel][PATCH] PV driver compatibility

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 22/01/2010 07:31, "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx> wrote:

> Yes, that's possible. I notice that I defined XEN_IOPORT_LINUX_PRODNUM
> and XEN_IOPORT_LINUX_DRVVER but then hardcode 0xdead and 0xbeef where
> they should be used, which suggests I wasn't quite ready to send the
> patch...

Hm, do you want to keep the deadbeef, or pick a nicer value, or remove the
patch?

> The protocol allows for coarse grained selection of which devices to
> unplug:
> 6) The drivers write a two-byte bitmask of devices to unplug to IO
>    port 0x10.  The defined fields are:

Well, the flexibility is nice, but not a feature that driver currently
actually uses.

My default action right now will be to add a module option to specify
selective or complete flushing, keep the patch, but only fail to load
drivers if flush is requested but not possible, otherwise just warn.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel