[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] Re: [PATCH 07/15] [swiotlb] In 'swiotlb_free' check iommu_sw pointer.
- To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
- From: Chris Wright <chrisw@xxxxxxxxxxxx>
- Date: Thu, 14 Jan 2010 18:02:40 -0800
- Cc: chrisw@xxxxxxxxxxxx, jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian.Campbell@xxxxxxxxxxxxx, joerg.roedel@xxxxxxx, fujita.tomonori@xxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, dwmw2@xxxxxxxxxxxxx, alex.williamson@xxxxxx
- Delivery-date: Thu, 14 Jan 2010 18:03:25 -0800
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
* Konrad Rzeszutek Wilk (konrad.wilk@xxxxxxxxxx) wrote:
> --- a/lib/swiotlb.c
> +++ b/lib/swiotlb.c
> @@ -364,7 +364,7 @@ cleanup1:
>
> void __init swiotlb_free(void)
> {
> - if (!iommu_sw->overflow_buffer)
> + if (!iommu_sw)
> return;
>
Sure this is safe for the case where allocation failed? Wouldn't this
do free_late_bootmem(__pa(0))?
thanks,
-chris
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|