[Xen-devel] Ping: c/s 20526 (tools: avoid cpu over-commitment if numa=on)

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

Andre,

I'm afraid this change isn't really correct:

>+                cores_per_node = info['nr_cpus'] / info['nr_nodes']
>+                nodes_required = (self.info['VCPUs_max'] + cores_per_node - 
>1) / cores_per_node

Simply using cores_per_node (as calculated here) as a divisor is bound
to cause division-by-zero issues, namely when limiting the number of
CPUs on the Xen command line (maxcpus=). I'm not sure though, what
a reasonable solution to this might look like, since cores-per-node is
a meaningless thing in an artificial setup like this, and may also be
meaningless in asymmetric configurations. So perhaps we really need
to iterate over nodes while summing up the number of CPUs they
have until the number of needed vCPU-s was reached.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel