Re: [Xen-devel] [PATCH][TOOLS] blktap: make memshr optional

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 12/01/2010 17:27, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> Christoph Egger writes ("[Xen-devel] [PATCH][TOOLS] blktap: make memshr
> optional"):
>> Attached patch makes memshr optional for blktap/blktap2.
>> This fixes build for platforms where memshr isn't build on.
> 
> That and ...
> 
>> While there, make indentation consistent.
> 
> ... this should be separated out, surely.
> 
> Mixing up a whitespace change with anything else is a recipe for
> making things hard to track down.

In this rare case it looked okay to me, as the whitespace changes are
exactly co-located with the patch's semantic changes. So the semantic
changes remain pretty clear in the diff.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel