Re: [Xen-devel] [PATCH, RFC 1/4] linux: add new (replacement) mmap-batch ioctl

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 12/01/2010 07:45, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> As does MMAPBATCH2. I actually strongly suggest IOCTL_PRIVCMD_MMAPBATCH_V2,
>> which makes the situation even more crystal clear. Distinguishing based on a
>> single underscore, to make the new name 'nice', is misplaced aestheticism.
>> In particular, the tools end up referencing both names (for compatibility)
>> and a clearer name makes the code more intelligible.
> 
> Okay, I'll change the name then. Before re-spinning the set, are there
> any other items that need fixing? Comments on the questions raised?

Looked okay to me. The only question I saw was regarding
xc_get_pfn_type_xxx: I don't think they are used outside libxc, so you can
do whatever makes internal sense for libxc (and remove the decls from
xenctrl.h).

> And are there chances this will still make 4.0? If not, can we at least
> add the interface definitions as place holders (similar to e.g. tmem
> before 3.4), allowing consuming code to be prepared for the addition?

It could go in for 4.0.0-rc2 I suppose.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel