[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] I cannot get any message from domU by console / pv_ops domU kernel crashes with xen_create_contiguous_region failed
> > void __init xen_swiotlb_init(void)
> > {
> > - if (xen_domain()) {
> > + int use_swiotlb = 0;
> > +
> > + if (xen_initial_domain())
> > + use_swiotlb = 1;
> > +
> > + /* For PV guest, only if iommu=soft is passed in. */
> > + if (xen_pv_domain() && !xen_initial_domain() && swiotlb)
> > + use_swiotlb = 1;
> > +
> > + if (use_swiotlb) {
>
> How about just
> if (xen_pv_domain() && (xen_initial_domain() || swiotlb))
That would work too. Let me remake the patch as it also has
spaces instead of tabs and fails the checkpatch.pl.
> Or depending on how/where swiotlb gets set (i.e. if it is set IFF
> xen_pv_domain) simply:
> if (xen_initial_domain() || swiotlb)
Can't do that, as it could on baremetal allocate the Xen-SWIOTLB.
>
> Ian.
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
