Re: [Xen-devel] [PATCH] Add memory hotadd to pvops dom0

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 20/12/2009 06:40, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:

>>>> +  struct xenpf_mem_hotadd        mem_add;
>>>> uint8_t                        pad[128];
>>>>        
>>> Should the size of the pad be decreased?
>>>      
>> This is defined by xen hypervisor, and is intended for extenstion in future,
>> I think.
> 
> But Konrad's point is that if you have padding to reserve space for
> future expansion, shouldn't you decrease the padding when you actually
> increase the structure?  Otherwise, if you can arbitrarily grow the
> structure, why do you need padding?

It's a union, dude!

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel