Re: [Xen-devel] [PATCH] linux/balloon: prefer using pages from balloon in alloc_empty_pages_and_pagevec()

[Dave McCracken <dcm@xxxxxxxx>]

On Friday 18 December 2009, Jan Beulich wrote:
> >>> Dave McCracken <dcm@xxxxxxxx> 17.12.09 21:33 >>>
> >
> >I don't see anything wrong with the error path.  It correctly walks back
> > down  the pagevec and frees all the pages it's allocated so far.
> 
> Oh, you're probably looking at the code past the err: label, but I was
> referring to the handling of a failed apply_to_page_range().

Ok, yeah.  It frees up the page that's currently being worked on, then jumps 
to err: to clean up all the other pages in the pagevec and free the pagevec.  
Is there something wrong about it that I'm missing?

Dave McCracken
Oracle Corp

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel