[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] Re: [PATCH 2] HVM vcpu add/remove: setup dsdt and madt infrastructure for vcpu add/remove
On 10/12/2009 12:08, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote: >> What's PROC_BASE, and what's APIC_MADT_PTR? No comments attached to >> them: they look like random magic numbers. > > KVM has vcpu add/remove code, these 2 items learn from KVM qemu/vbios/dsdt > code. > Since they belong to qemu & vbios part, I think we'd better keep same with > KVM. > I will add comments for them at updated patch. Oh, I categorically do not care about keeping these magic numbers the same as KVM/qemu. If there are some ioports or iomem emulated at fixed address by qemu then that's one thing, but keeping their vbios random numbers when we *do not use* the same vbios makes no sense. I'd rather keep our MADT layout, add a few lines of code to hvmloader to describe some MADT position/layout parameters to the DSDT via the bios_info structure, and go from there. Smaller, clearer patch, as far as I can see. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |