Re: [Xen-devel] [PATCH] libxenlight: fix multiple xenstore watches problem

[Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>]

On Thu, Dec 03, 2009 at 03:39:57PM +0000, Stefano Stabellini wrote:
> You are right about that, but Andres found the bug and fixed it with his
> "clone context to avoid GC corruption" patch.

that's not about whether or not it can works. I think it's just confusing to
clone and share a context in a mono thread where the only thing you want out of
it, is a xenstore handle. You can simply clone a new xs handle, and worst case
scenario, you can extends the xl context to store 2 xs connections.

In the end, the approch is overkill, and complex solution often lead to
unforseen bug (at this was the case here)

> We can limit the memory allocated for the new alloc_ptrs to something
> much smaller than 256 in libxl_clone_context if you are worried about
> memory allocation.

definitely not worried about that.  libxenlight is not a library where
performance matters. (not that i'm saying it will be slow either)

-- 
Vincent

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel