Re: [Xen-devel] Re: Crash with c/s 20097 (x86 vmx: Update EIP when appropriate during task switch)

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 13:42 +0000 on 02 Dec (1259761336), Keir Fraser wrote:
> I refactored the code as xen-unstable:20561. If that looks agreeable and
> correct to you then I will also backport to 3.4-testing.

Looks fine to me. 

> > Fortunately we never inject software interrupts or exceptions. I reworked
> > the code to avoid that a long time ago, due to just such concerns. Possibly
> > we should even ASSERT as such in the event-injection functions.
> 
> I decided against this because we write to VM_ENTRY_INTR_INFO in a few
> places so it's not nice and centralised. But it's pretty obvious that SWInts
> and SWExcs are not in the picture since we never write
> VM_ENTRY_INSTRUCTION_LENGTH. So we're obviously safe (or even more utterly
> broken :-) ).

That's grand then. :)

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel