[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: don't leak IRQs over suspend/resume.



>>> Ian Campbell <ian.campbell@xxxxxxxxxx> 01.12.09 17:15 >>>
>On resume irq_info[*].evtchn is reset to 0 since event channel mappings are not
>preserved over suspend/resume. The other contents of irq_info is preserved to
>allow rebind_evtchn_irq() to function.
>
>However when a device resumes it will try to unbind from the previous IRQ (e.g.
>blkfront goes blkfront_resume() -> blkif_free() -> unbind_from_irqhandler() ->
>unbind_from_irq()). This will fail due to the check for VALID_EVTCHN in
>unbind_from_irq() and the IRQ is leaked. The device will then continue to
>resume and allocate a new IRQ, eventually leading to find_unbound_irq()
>panic()ing.
>
>Fix this by changing unbind_from_irq() to handle teardown of interrupts which
>have type!=IRQT_UNBOUND but are not currently bound to a specific event
>channel.

This seems applicable to the 2.6.18/.27 trees too, doesn't it?

Jan 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.