Re: [Xen-devel] [PATCH] libxenlight: add console command

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 1 Dec 2009, Vincent Hanquez wrote:
> On Fri, Nov 27, 2009 at 10:40:02AM +0000, Tomasz Wroblewski wrote:
> > Hello all,
> > 
> > This patch adds "xl console" command similar to "xm console".
> >  
> > Signed-off-by: Tomasz Wroblewski <tomasz.wroblewski@xxxxxxxxxx>
> > ---
> > 
> > diff -r d7d77bace286 tools/libxl/libxl.c
> > --- a/tools/libxl/libxl.c   Fri Nov 27 10:13:42 2009 +0000
> > +++ b/tools/libxl/libxl.c   Fri Nov 27 10:18:18 2009 +0000
> > @@ -468,6 +468,24 @@
> >      if (rc < 0) {
> >          XL_LOG_ERRNOVAL(ctx, XL_LOG_ERROR, rc, "xc_domain_destroy
> > failed for %d", domid);
> >          return -1;
> > +    }
> > +    return 0;
> > +}
> > +
> > +int libxl_console_attach(struct libxl_ctx *ctx, uint32_t domid, int
> > cons_num)
> > +{
> > +    struct stat st;
> > +    const char *XENCONSOLE = "/usr/lib/xen/bin/xenconsole";
> > +    char *cmd = NULL;
> > +
> > +    if (stat(XENCONSOLE, &st) != 0) {
> > +        XL_LOG(ctx, XL_LOG_ERROR, "could not access %s", XENCONSOLE);
> > +        return ERROR_FAIL;
> > +    }
> > +
> > +    cmd = libxl_sprintf(ctx, "%s %d --num %d", XENCONSOLE, domid,
> > cons_num);
> > +    if (system(cmd) != 0) {
> > +        return ERROR_FAIL;
> >      }
> >      return 0;
> >  }
> 
> I don't think that should be a API call of the libxenlight library.
> I find hard to think that anyone except a command line tool would use such a
> call. please move it to xl.c completly.
> 

I think there should be an API call for this, but let this issue aside
for a moment: this is needed at the very least to get logging information
from stubdoms.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel