Re: [Xen-devel] [PATCH 07 of 10] Transitive grant support

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 05/10/2009 12:15, "Steven Smith" <Steven.Smith@xxxxxxxxxxxxx> wrote:

>>> correct, while we're rev'ing a public interface. Given the definition of
>>> __spacer[], it looks like there's space to have a full 'uint64_t frame' in
>>> that structure too, no problem. A bit of field reordering might be needed to
>>> make everything align naturally yet compactly, is all, I think?
>> Agreed. Not sure though whether uintXX_t is the right thing to use -
>> after all we have xen_pfn_t for exactly this purpose.
> Maybe.  xen_pfn_t probably would be the right type, but, again, it's
> not 32/64 clean, which means it'd need some compat stuff.  Not
> impossible, but kind of annoying.
> 
> Would something like this be acceptable?

Yes, that would be fine by me. I think continuing with xen_pfn_t and making
another shared grant structure be 32/64-bit unclean would be a mistake. A
uint64_t is clearly going to be big enough.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel