Re: [Xen-devel] [PATCH] Don't free irqaction for com irq when release irq.

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 03/09/2009 17:26, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

> Oops yes, thanks for pointing that out.  This won't
> be the first or last time I've been fooled by that
> convention.
> 
> For the sake of good programming practices and
> (self-)documentation, since "don't free" is
> a rare exception rather than the rule, may
> I suggest changing the name/sense of the variable
> in the struct to "dont_free", for which zero is
> a reasonable default, and just enabling
> it for the com irqs?

All irqactions which *should* be freed are allocated in exactly one place.
It is therefore sensible to make that the 'exception' which sets a flag to
1. The variou sother users of the setup_irq() interface then do not need to
be changed, as they get a default flag value of zero.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel