RE: [Xen-devel] [pvops-dom0] Adding MCA logging support in pv_ops

["Ke, Liping" <liping.ke@xxxxxxxxx>]

Hi, all
I modified the patch according to all feedbacks.
Mainly changes inlcudes:
1. Rebased code to "rebase/master" branch 2.6.31-rc4. We fetch more
    useful physical cpu information which is useful to mcelog tools.
2. Modified the code for defects/ kernel conventions according to feedback.
3. Update out of date comments and add neccessary comments according
   to feedback.

This patch is only for your review. I will resend the formated patch later.
Also, I will re-sync the xen-mca.h head file changes back to XEN after review.

Thanks a lot for your help!
Criping

Jeremy Fitzhardinge wrote:
> On 07/30/09 02:23, Ke, Liping wrote:
>> Hi, Jan
>> 
>> I also noticed that in .31, several important missing field such as
>> apic_id, socket id is added. Those field is better to be filled too.
>> Since now pv_ops is based on .30, those changes haven't happen yet.
>> 
>> So what's your suggestion? Seems we have to keep the old code and
>> make 
>> a patch to it when .31 is supported in pv_ops?
>> 
> 
> The "rebase/master" branch is based on 2.6.31-rc4.  It looks like your
> patch doesn't really have any other code-level dependencies on the
> dom0 changes, so you could just base it on upstream 2.6.31-rc4.
> 
>     J

Attachment: mce_pvops.patch
Description: mce_pvops.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel