Re: [Xen-devel] [PATCH] Add script to compile different versions of python; add python syntax checker

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 29/07/2009 05:40, "Andreas Florath" <xen@xxxxxxxxxxxx> wrote:

> just recognised that the patch was applied - but the directory is now
> different from the original.  This breaks the Makefile and the provided
> scripts.
> 
> I'll send a patch against the current tip this evening.

Ah, I just assumed it would all be relative to the directory it's resident
in. Of course XEN_ROOT does need fixing (I forgot about that), but then you
can make yourself a local-dir variable based directly on $(PWD) rather than
$(XEN_ROOT).

Also, at the same time it would be good if you would replace ${} make
variable expansions with $(). It's purely a style consistency thing, as we
use the latter in all other Makefiles.

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel