[Xen-devel] RE: [PATCH]xend: pass-through: fix "xm pci-list-assignable-devices' for pv_guest

["Cui, Dexuan" <dexuan.cui@xxxxxxxxx>]

Simon Horman wrote:
>> pci_dict_to_bdf_str(new_dev)) +        pci_name =
>> '%04x:%02x:%02x.%x' % \ +          (parse_hex(new_dev['domain']),\
>> +           parse_hex(new_dev['bus']),\
>> +           parse_hex(new_dev['slot']),\
>> +           parse_hex(new_dev['func']))
> 
>   You should be able to use pci_name = pci_dict_to_bdf_str(new_dev)
>   here instead of the above 5 lines.
Hi Simon,
Agree.  Your suggestion is good. 


> 
>> +        if pci_name in get_all_assigned_pci_devices():
>> +            raise VmError("failed to assign device %s that has"
>> +                          " already been assigned to other domain."
>> % pci_str) 
> 
>   Should pci_str be pci_name in the line above ?
Thanks a lot for the careful review!
Actually I corrected the mistake in my side, but I didn't send the latest 
version... :-(
I'll ack the fix you sent out just now.


Thanks,
-- Dexuan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel