Re: [Xen-devel] [PATCH] tools: use C99 __VA_ARGS__

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Christoph Egger writes ("Re: [Xen-devel] [PATCH] tools: use C99 __VA_ARGS__"):
> On Tuesday 21 July 2009 15:26:14 Ian Jackson wrote:
> > Christoph Egger writes ("[Xen-devel] [PATCH] tools: use C99 __VA_ARGS__"):
> > > Attached patch switches tools to consistently use C99 __VA_ARGS__.
> >
> > What is the benefit of this ?
> 
> Consistency in the whole tree in combination with two other patches
> (xen-kernel and minios) which I have not yet submitted.

Umm, so what's the benefit of the whole patchset ?

> > Xen requires GCC and the GCC variable 
> > argument list extension has been around forever,
> 
> That's not a reason to stick on old things.

Neither is there apparently any reason to change.

> > so it doesn't seem to aid portability.
> 
> No, not in this case.
> 
> But the other patch for the xen-kernel touches
> the public headers.
> AFAIK the public headers should follow the standard.

Do the public headers currently work with other compilers ?  There is
an argument for using the standard syntax there to make it easier for
kernels compiled with non-GCC compilers to provide Xen guest support.

> > The GCC syntax is considerably prettier than the C99 one.
> 
> This is subjective.

Nevertheless it is true.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel