Re: [Xen-devel] [RFC] [PATCH] One watchdog trips the watchdog on allprocessors

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> George Dunlap <dunlapg@xxxxxxxxx> 17.07.09 14:55 >>>
>...
>+static void do_nmi_trigger_cpu(int cpu)
>+{
>+    u32 id = cpu_physical_id(cpu);
>+
>+    printk("Triggering NMI on APIC ID %x\n", id);
>+    debugtrace_dump();
>+
>+    local_irq_disable();
>+    apic_wait_icr_idle();
>+    apic_icr_write(APIC_DM_NMI | APIC_DEST_PHYSICAL, id);
>+    local_irq_enable();

You definitely don't want to enable interrupts inside an NMI. I don't think
you need to disable them either, as nothing else should have enabled
them.

>...
>+                for_each_cpu(cpu)

This is for_each_possible_cpu() now.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel