[Xen-devel] [PATCH] tools: portability fixes

[Christoph Egger <Christoph.Egger@xxxxxxx>]

Hi!

Attached patch makes gtraceview compile on NetBSD.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

@Guanqun.Lu:
1. Why do you hardcode -lncurses, when there is a CURSES_LIBS variable ?
    The existence of it should have ring an alarm bell that your code isn't
    portable, i.e. that you can't blindly include <ncurses.h>.
2. The string operations look dangerous in respect to security. Please fix 
them.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Attachment: xen_gtrace.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel