RE: [Xen-devel] [PATCH 2/2] passthrough: deliver IRQs even if bsp is halted (support kexec/kdump on hvm)

["Cui, Dexuan" <dexuan.cui@xxxxxxxxx>]

> @@ -437,7 +444,7 @@ void hvm_dirq_assist(struct vcpu *v)
>      struct hvm_irq_dpci *hvm_irq_dpci = d->arch.hvm_domain.irq.dpci;
>      struct dev_intx_gsi_link *digl;
>  
> -    if ( !iommu_enabled || (v->vcpu_id != 0) || (hvm_irq_dpci == NULL) )
> +    if ( !iommu_enabled || (hvm_irq_dpci == NULL) )
>          return;
>  
>      for ( irq = find_first_bit(hvm_irq_dpci->dirq_mask, d->nr_pirqs); 

With the patch applied, every vcpu of a domain can access the 
hvm_irq_dpci->dirq_mask concurrently!
I think some usage of spinlock must be introduced if you'd like to do so.

Thanks,
-- Dexuan



-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Kouya Shimura
Sent: 2009?6?30? 14:57
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Cc: Keir Fraser
Subject: [Xen-devel] [PATCH 2/2] passthrough: deliver IRQs even if bsp is 
halted (support kexec/kdump on hvm)

This patch is needed for kexec/kdump on hvm since kdump halts bsp.

Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel