Re: [Xen-devel] [PATCH 5 of 5] qemu: implement support for secondary consoles in the console backend

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

Gerd Hoffmann wrote:

>    Hi,
> 
>> +    if (!xendev->dev)
>> +        snprintf(con->console, sizeof(con->console), "%s/console", dom);
>> +    else
>> +        snprintf(con->console, sizeof(con->console), 
>> "%s/device/console/%d", dom, xendev->dev);
> 
>> +    if (!xendev->dev)
>> +        con->sring = xc_map_foreign_range(xen_xc, con->xendev.dom,
>> +    else
>> +        con->sring = xc_gnttab_map_grant_ref(xendev->gnttabdev, 
>> con->xendev.dom,
> 
>> +        if (!xendev->gnttabdev)
>> +        munmap(con->sring, XC_PAGE_SIZE);
>> +        else
>> +            xc_gnttab_munmap(xendev->gnttabdev, con->sring, 1);
> 
> This should check for xendev->dev too, like the other ones.

right.

> Also this changes code already merged to upstream qemu, so it should be 
> crossposted to qemu-devel.


I'll do.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel