[Xen-devel] Re: [PATCH] disallow duplicate pci device strings in guest config file

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

Why is the right answer not: Don't do that, then?

 -- Keir

On 15/05/2009 12:31, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> When we specify duplicate pci device strings in guest config file, like
> pci=['01:00.0', '01:00.0'], or  pci=['01:00.0', '0000:01:00.0'], or
> pci=['01:00.0', '0000:01:00.0@7'],
> xend doesn't detect this case and passes the pci string to ioemu and ioemu
> invokes register_real_device() twice for the same physical device and this
> could cause unexpected behavior.
> 
> The patch detects this case and makes the domain construction fail.
> 
> Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel