[Xen-devel] Re: [PATCH FIXED] x86: use flush_tlb_others to implement flush_tlb_all

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

Ian Campbell wrote:
> get_cpu() returns smp_processor_id() so wouldn't this be more normally
> written as:
>         /* flush_tlb_others expects preempt to be disabled */
>         unsigned long cpu = get_cpu();
>         [....]
>         if ([....] == TLBSTATE_LAZY)
>                 leave_mm(cpu)
>         put_cpu();
>   
Quite so.  In theory gcc should be able to CSE smp_processor_id(), but 
the intent of get_cpu() is that you use its return value...
   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel