[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] Re: [PATCH 1/9] xen: make sure swiotlb allocation is physically contigious
Joerg Roedel wrote: +} + +void *swiotlb_alloc(unsigned order, unsigned long nslabs) +{ + /* Never called on x86. Warn, just in case. */Can't this function be removed completly then? The swiotlb code contains a static call, which never ends up being executed, so there has to be something to be called. But you're right that there's no particular reason for this warning unless someone starts to call swiotlb_alloc in the future. I'd briefly discussed the idea of eliminating the distinction between boot and post-boot swiotlb allocation, but it looks tricky to implement. + + if (xen_create_contiguous_region((unsigned long)buf, + order, 0xffffffff))DMA_32BIT_MASK? OK (ditto other mentions). J _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |