Re: [Xen-devel] do_domctl and EAGAIN

[Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>]

Keir Fraser wrote:
> Only DOMCTL_destroydomain returns EAGAIN. No domctl returns EINTR.

do_domctl uses ioctl.
ioctl can return EINTR if a signal is caught.

Other hypercalls do return EAGAIN.

Juergen

> 
>  -- Keir
> 
> On 07/04/2009 08:04, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:
> 
>> Hi,
>>
>> certain domctl hypercalls (and possibly others as well) might fail with errno
>> EAGAIN. This case seems to be tested only in very few places, e.g. in
>> xc_domain_destroy.
>>
>> Is there any reason why this case isn't handled in do_domctl?
>> Shouldn't EINTR be handled as well?
>>
>> The other solution would be to have two versions of do_domctl, one of them
>> looping in case of EAGAIN or EINTR.
>>
>> I suspect this lack of errno-testing could lead to very sporadic failures...

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 636 47950
Fujitsu Technolgy Solutions               e-mail: juergen.gross@xxxxxxxxxxxxxx
Otto-Hahn-Ring 6                        Internet: ts.fujitsu.com
D-81739 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel