[Xen-devel] [PATCH] xend: fix leak of /local/domain/* in xenstore

[Kouya Shimura <kouya@xxxxxxxxxxxxxx>]

My previous patch seems to be missing. so I resend.

xenwatch thread _storeChanged() may create /local/domain/<domid> entries
in xenstore even after the domain has shutdown.

Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>

diff -r 5a60eb7fad79 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Thu Apr 02 14:17:19 2009 +0100
+++ b/tools/python/xen/xend/XendDomainInfo.py   Tue Apr 07 15:08:57 2009 +0900
@@ -1634,7 +1634,13 @@ class XendDomainInfo:
         if changed:
             # Update the domain section of the store, as this contains some
             # parameters derived from the VM configuration.
-            self._storeDomDetails()
+            self.refresh_shutdown_lock.acquire()
+            try:
+                state = self._stateGet()
+                if state not in (DOM_STATE_SHUTDOWN, DOM_STATE_HALTED,):
+                    self._storeDomDetails()
+            finally:
+                self.refresh_shutdown_lock.release()
 
         return 1
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel