Re: spinlock requests (was RE: [Xen-devel] [Patch] don't spin with irq disabled)

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 03/04/2009 00:08, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> Well the race is still impossible afaics. Unless your
>> _raw_rw_is_write_locked() was checking for ==0 rather than
>> <=0.
> 
> Finally got a chance to go back and reproduce and figure
> this one out.  The crash is still occurring.  My code
> definitely checks for <=0.  BUT the declaration of
> raw_rwlock_t declares the lock as "volatile UNSIGNED int",
> so the compiler blithely generates a check for == 0.
> 
> Can I assume the fix is to change the declaration to
> int instead of unsigned int, or will that cause problems
> elsewhere?

Oh dear. Yes, that's the fix!

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel